Repository navigation
feat(xmr): sign and verify messages - #1509
Merged
Merged
Conversation
Implement SignVerifyInterface on LibMoneroWallet so Monero wallets get the existing Sign / Verify view. cs_monero 4.0.0 already wraps MONERO_Wallet_signMessage and MONERO_Wallet_verifySignedMessage, so this only forwards them through CsMoneroInterface. Signatures are wallet2 SigV2 spend-key signatures for the chosen primary address or subaddress, compatible with monero-wallet-cli/rpc sign and verify. wallet2 returns an empty string instead of throwing when signing fails, so treat that as an error. View-only wallets cannot sign.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1509 +/- ##
===========================================
+ Coverage 14.01% 14.08% +0.06%
===========================================
Files 1139 1139
Lines 114724 114742 +18
===========================================
+ Hits 16078 16156 +78
+ Misses 98646 98586 -60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement SignVerifyInterface on LibMoneroWallet so Monero wallets get the existing Sign / Verify view. cs_monero 4.0.0 already wraps MONERO_Wallet_signMessage and MONERO_Wallet_verifySignedMessage, so this only forwards them through CsMoneroInterface.
Signatures are wallet2 SigV2 spend-key signatures for the chosen primary address or subaddress, compatible with monero-wallet-cli/rpc sign and verify. wallet2 returns an empty string instead of throwing when signing fails, so treat that as an error. View-only wallets cannot sign.